Repository navigation
chore(autoreview): use the shared canonical skill - #120
Conversation
|
Codex review: needs maintainer review before merge. Reviewed October 8, 2026, 12:55 AM ET / 04:55 UTC (Revision 6). ClawSweeper reviewWhat this changesReplace the repository’s copied autoreview helper and tests with shared-installation guidance while retaining its P0–P3 review gate. Example: A contributor reviews a non-trivial change
Review scores
ProductKind: Maintenance · Worth it: Yes Merge readiness✅ Ready for maintainer review This PR remains useful and has no identified merge blocker. The refreshed head resolves the previous changelog conflict, preserves the review threshold, and uses the merged canonical installation contract. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherAutoreview checks proposed repository changes before contributors ship them. The repository supplies its working directory and review requirements to a shared helper, which returns structured findings. flowchart TD
A[Contributor changes] --> B[Repository review instructions]
B --> C[Shared installation setup]
C --> D[Installed review helper]
E[Repository working directory] --> D
F[P0 through P3 threshold] --> D
D --> G[Structured review findings]
Technical reviewBest possible solution: Keep one upstream implementation and test owner, with explicit consumer setup and repository-specific review thresholds. Do we have a high-confidence way to reproduce the issue? Not applicable: this is tooling consolidation rather than a reported runtime bug; source confirms the copied implementation remains on current main. Is this the best way to solve the issue? Yes. The existing canonical installer and working-directory-aware helper support this cutover without a parallel implementation, and explicit P3 arguments preserve the repository contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5f1c98b00c69. Provenance checked
TestingProof path: shipped entry point. Added test files: 0. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (5 earlier review cycles)
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions retain the original P0–P3 review gate with
--max-priority P3. The shared entrypoint remains identical to the canonical template. Refreshed main inc1fa2491515f0a98c3866cc71c26f5b9ab641116; the changelog conflict preserves both entries and leaves the reviewed migration unchanged. Diff checks and all required hosted checks pass. The organization admin explicitly authorized bypassing the missing code-owner review for this PR. Exact headc1fa2491515f0a98c3866cc71c26f5b9ab641116has all required CI checks passing, a completed independent review with no findings or before-merge items, and no unresolved review threads. This exception applies only to the missing review; repository settings and CI requirements are unchanged.