feat(slides): support public image URLs#832
Merged
Merged
Conversation
Collaborator
Author
|
Landed as Proof:
Caveat: the live account does not enforce the reporter's restricted-tenant sharing policy. The regression tests prove the new URL paths never initialize Drive, while the live test proves the direct Slides API fetch/cache path works end to end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--urlsources toslides insert-imageandslides replace-slideCloses #825.
Testing
go test ./internal/cmd -run 'Test(ResolveSlidesImageSource|SlidesInsertImage|SlidesReplaceSlide)' -count=1make ci/Users/steipete/Projects/agent-skills/skills/autoreview/scripts/autoreview --mode local --stream-engine-output(clean after fixing its accepted path-preservation finding)trashed=trueCaveat
The live account permits Drive sharing, so it cannot reproduce the tenant policy error itself. Unit tests prove both URL commands never initialize Drive, while the live test proves Google Slides accepts and caches the direct URL requests.