fix(calendar): hint truncated event pages#831
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: needs real behavior proof before merge. Reviewed June 17, 2026, 2:27 AM ET / 06:27 UTC. Summary Reproducibility: yes. Source inspection shows current main's multi-calendar Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land a narrow fix that surfaces calendar event truncation without corrupting stdout, and decide separately whether multi-calendar JSON needs per-calendar pagination metadata. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main's multi-calendar Is this the best way to solve the issue? Mostly yes for text output: capturing per-calendar tokens and printing a stderr hint follows the repo's parseable-stdout convention. The open solution question is whether multi-calendar JSON should also expose per-calendar continuation data instead of only preserving the existing JSON shape. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f371f43eaef3. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Behavior proof from current PR head I exercised the single-calendar The committed focused regression coverage also passes for single-calendar text/JSON and all-calendar text/JSON pagination paths. |
|
@clawsweeper review |
|
I checked whether I could provide the requested real Calendar API pagination proof from this machine. I cannot do that honestly here: On the JSON boundary: this PR intentionally leaves the existing JSON output shape unchanged. The new truncation signal is a stderr hint for table/plain output so stdout remains parseable. If maintainers want machine-readable per-calendar continuation metadata for |
|
Real Calendar API behavior proof from current PR head Environment/proof scope:
Terminal proof: This shows the real Calendar API pagination case produces event table output on stdout and the pagination hint on stderr, so stdout remains parseable. JSON boundary proof from the same real API setup: That matches the intended boundary for this PR: text/table mode gets a stderr truncation hint; JSON mode remains parseable and keeps the existing top-level Validation: GitHub CI is also green on this PR: |
|
@clawsweeper review |
Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
|
Landed as 7712dc6. Verification:
The JSON change is additive: existing |
Follow-up to #821 for multi-calendar listings.
Summary
nextPageTokensmetadata in JSONeventsarrayVerification
go test ./internal/cmd -run 'TestListAllCalendarsEvents|TestExecute_CalendarEvents' -count=1make cicalendar events --all --max=1: JSON parsed successfully with two events and two per-calendar page tokens; stderr was empty