test(docs): validate markdown link anchors#812
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 15, 2026, 1:34 AM ET / 05:34 UTC. Summary Reproducibility: not applicable. this is a docs tooling PR rather than a reported runtime bug. Source inspection confirms current main does not validate Markdown fragments in Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow docs-check anchor validator after proof shows both a broken fragment being rejected and the current valid docs set passing on the latest head. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a docs tooling PR rather than a reported runtime bug. Source inspection confirms current main does not validate Markdown fragments in Is this the best way to solve the issue? Yes, pending proof: extending the existing docs coverage script and adding focused Node regression coverage is a narrow maintainable path. The safer merge posture is to require real command output for the broken-anchor failure path on the latest head. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 23b847ca53cf. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Follow-up pushed in What changed:
Local proof: |
Co-authored-by: Kiran Magic <kiran@Alices-Laptop.local>
|
Latest-head proof for Broken-fragment failure path: After removing the temporary proof file, the valid docs set passes: @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
Verification
make docs-checknode scripts/check-docs-coverage.mjsgit diff --check