fix(calendar): parse freebusy date ranges like events#811
Conversation
|
Codex review: found issues before merge. Reviewed June 15, 2026, 1:00 AM ET / 05:00 UTC. Summary Reproducibility: yes. from source inspection. Current main forwards Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the calendar parser fix after maintainer review, with release-note handling owned by the landing/release process and exact-head checks settled. Do we have a high-confidence way to reproduce the issue? Yes from source inspection. Current main forwards Is this the best way to solve the issue? Yes for the runtime fix: reusing Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4a532bb86db2. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
24135a6 to
58ddad3
Compare
71cc39d to
58ddad3
Compare
|
@clawsweeper stop |
|
🦞✅ I added |
e4bd197 to
58ddad3
Compare
Summary
calendar freebusy --from/--tothrough the existing calendar time range parser before calling the FreeBusy API.todayandtomorrow.Fixes #806
Release note context
gog calendar freebusy --from/--tonow accept the same RFC3339, date-only, and relative date expressions asgog calendar events.Validation
make fmtmake docs-commandsgo test -vet=off ./internal/cmd -run 'TestCalendarFreeBusyCmd_ResolvesCalendarName|TestCalendarFreeBusyCmd_RelativeRangePayload'make test TEST_PKGS=./internal/cmdmake ciClawSweeper 🐠 replacement reef notes:
gog calendar freebusy --from/--tonow accept RFC3339, date-only, and relative expressions such astodayandtomorrow, matchinggog calendar events.fish notes: reasoning high; reviewed against 1f38cb9.