Repository navigation
fix(ci): recover retained checkpoint publication - #290
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes: an initial private checkpoint can remain unpublished after its assets upload and a later migration step fails.
User Impact
Operators can explicitly finalize the retained checkpoint after a successful read-only diagnostic and two complete verified restores. Original provenance and assets remain unchanged. This is a manual recovery operation; uncertain publication outcomes stop for inspection.
Why This Change Was Made
The existing migration owns checkpoint creation, so recovery reuses its exact retained draft and canonical restore validation. Finalization verifies the diagnostic's actual job, inputs and executed markers, then checks every part, database hash, SQLite integrity and table facts twice. It repeats source and custody admission before one publication request, with bounded work and no retry after an ambiguous response.
No schema, credential, collection, upload, cache deletion or scheduling change is included. Production Python grows by 182 lines and workflow code by 36 lines to enforce this recovery boundary; tests grow by 304 lines.
Evidence
c80101b; CI run 39044023410 completed all 12 jobs successfully. Its merge tree matches the reviewed source exactly.