Repository navigation
chore(autoreview): use the shared canonical skill - #268
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. Reviewed October 6, 2026, 1:02 PM ET / 17:02 UTC (Revision 9). ClawSweeper reviewWhat this changesThe branch replaces Discrawl’s copied review helper and tests with instructions for using the shared autoreview installation and adds a changelog entry. Merge readiness⛔ Needs changes before merge - 1 item remains The consolidation remains useful and is not implemented on the pinned main branch or latest release. No actionable defect was found; the member-authored PR remains a draft. Priority: P3 Review scores
Verification
How this fits togetherAutoreview checks proposed repository changes before shipping. The repository entrypoint directs operators to a shared installation, which reviews Discrawl from its working directory and returns findings. flowchart TD
A[Proposed repository changes] --> B[Discrawl review instructions]
B --> C[Shared skill installed]
C --> D[Review from Discrawl directory]
D --> E[Structured findings]
E --> F[Contributor verification]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep review implementation and regression coverage upstream, with Discrawl retaining a clear install/update entrypoint and its independent CI secret scanning. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a tooling consolidation, and no current product failure or introduced defect is established. Is this the best way to solve the issue? Yes: using the existing canonical installation avoids copied implementation drift, and the documented installer supports both symlink and copy modes. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 52470d9c7187. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (8 earlier review cycles)
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(autoreview): use the shared canonical skill This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests. Keep the existing narrow synthetic-fixture allowlist unchanged because CI still scans Git history.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.CI initially found two history-scan matches after removing that allowlist; it is restored byte-for-byte from the base commit. The shared review helper remains scanner-free.
Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.