Repository navigation
chore(autoreview): use the shared canonical skill - #152
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. Reviewed October 6, 2026, 4:56 AM ET / 08:56 UTC (Revision 12). ClawSweeper reviewWhat this changesReplace crawlkit’s copied autoreview helper and tests with instructions for using the shared installation, and add a changelog entry. Merge readiness⛔ Needs changes before merge - 1 item remains This remains useful: current main still vendors the old implementation, and no introduced defect was found. The member-authored PR remains draft with confirmed merge conflicts. Priority: P3 Review scores
Verification
How this fits togetherAutoreview is developer tooling that takes repository changes and produces structured review findings. This change directs developers to the centrally maintained helper while preserving crawlkit’s local review requirements. flowchart TD
A[Repository changes] --> B[Local skill entrypoint]
B --> C{Shared skill installed?}
C -->|No| D[Operator installs shared skill]
D --> E[Shared review helper]
C -->|Yes| E
E --> F[Structured findings]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Maintain one canonical review implementation with an explicit operator installation path and repository-specific policy retained locally. Do we have a high-confidence way to reproduce the issue? Not applicable: this is tooling consolidation, and no discrete introduced bug was identified. Is this the best way to solve the issue? Yes: delegating historical canonical copies to the existing shared installation is a focused way to prevent drift; repository policy remains local. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 288e02a35fea. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (11 earlier review cycles; latest 8 shown)
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(autoreview): use the shared canonical skill This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.