Repository navigation
chore(autoreview): use the shared canonical skill - #335
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review blockedAutomated review did not run, so no review verdict was produced. Reason: The input-safety check rejected material in this revision. No detected value, path, or scanner output is reproduced here. Automatic review is on hold, including after source changes. Request a fresh re-review after resolving the failure; maintainers can also release the hold through an intentional scanner-policy update. Next step: If this is a genuine credential, remove and rotate it. If it is an intentional test fixture, a maintainer must review and qualify it. |
|
Codex review: blocked before merge. Reviewed October 2, 2026, 6:59 PM ET / 22:59 UTC (Revision 4). ClawSweeper reviewWhat this changesReplace Crabline’s copied autoreview helper and tests with a shared-skill entrypoint, removing their local package verification wiring. Merge readiness⛔ Blocked before merge - 2 items remain This remains useful cleanup absent from main. The earlier compatibility blocker is still unresolved, and the MEMBER-authored PR remains open for maintainer handling. Priority: P3 Review scores
Verification
How this fits togetherAutoreview supports contributor code review rather than Crabline’s provider runtime. The repository entrypoint directs agents to an installed shared helper, which reviews changes from the consumer repository’s working directory. flowchart TD
A[Repository changes] --> B[Local review entrypoint]
B --> C[Shared skill installation]
C --> D[Review helper]
A --> D
D --> E[Structured review results]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one canonical implementation while preserving Crabline’s existing launcher and harness guarantees throughout the shared-installation transition. Do we have a high-confidence way to reproduce the issue? Not applicable to this tooling cleanup; source and live upstream metadata establish the landing-order gap without executing a review. Is this the best way to solve the issue? Yes, centralizing the implementation uses the existing installer and avoids copy drift, provided the upstream transfer lands before consumer removal. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 48a8cc967026. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests. Remove the duplicate test launcher and its package/test wiring. Its useful launcher and harness fixes are preserved in the upstream PR.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.node --check; package JSON parses. Runtime tests/formatters were not run locally because the dependency installation is absent.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.