Repository navigation
fix(worker): re-pin the AWS RDS global CA bundle - #2853
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs changes before merge. What this changesUpdates the Node coordinator image’s AWS RDS CA bundle checksum, matching assertion, and changelog entry. Example: Build the Node coordinator image after AWS updates global-bundle.pem.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Needs changes before merge - 1 item remains Keep this PR open: current main and v0.78.0 retain the old checksum, and the focused repair remains necessary; GitHub reports a merge conflict. Priority: P2 Before merge
FindingsNone. Agent review detailsHow this fits togetherThe container build downloads a checksum-pinned AWS RDS certificate bundle into the portable Node coordinator image, where operators can select it for verified PostgreSQL TLS connections. flowchart LR
A[AWS RDS truststore] --> B[Checksum verification]
B --> C[Node coordinator image]
C --> D[PostgreSQL TLS client]
E[Database URL settings] --> D
D --> F[RDS database]
Technical reviewBest possible solution: Land the verified checksum refresh while preserving checksum enforcement and PostgreSQL-scoped trust. Do we have a high-confidence way to reproduce the issue? Main retains the reported stale checksum and fails the image-build step, whereas the reviewed head passes it; the precise checksum-error log was unavailable through the allowed network. Is this the best way to solve the issue? The narrow checksum refresh follows the established repair and preserves the existing trust boundary without adding configuration or runtime behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 865f4fcccc0f. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 15, 2026, 2:35 AM ET / 06:35 UTC. |
f4676b1 to
f09739f
Compare
Problem
Worker CI now fails the Node image build (
worker/Dockerfile.node) at the pinnedADD --checksumforhttps://truststore.pki.rds.amazonaws.com/global/global-bundle.pem: AWS reissued the bundle. Pinned SHA-256fe45bbeb…395c, served SHA-25690a6f1a7978a1b1b096dca6c57511ca48d3b8cf052f8e704baf358f34ea2f21b(174,560 bytes). This blocks every PR, including the v0.78.1 release prep (#2852).Verification of the new bundle
Fetched independently over AWS's official HTTPS endpoint: same digest. 114 certificates (previously 111, per #2618); every subject and issuer is
O=Amazon Web Services, Inc., OU=Amazon RDS, every certificate passes self-signature/CA checks. The three newest are theAmazon RDS sa-west-1 Root CARSA2048 / RSA4096 / ECC384 G1 certificates issued 2026-09-02 — consistent with AWS adding a region, not a substitution.Change
Re-pin the checksum in
worker/Dockerfile.nodeand its assertion inscripts/aws-ecs-fargate-coordinator.test.js(7/7 pass). Trust stays scoped to PostgreSQL viasslrootcertas documented.