Repository navigation
chore(autoreview): use the shared canonical skill - #2663
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 6, 2026, 2:49 PM ET / 18:49 UTC (Revision 3). ClawSweeper reviewWhat this changesReplaces Crabbox’s copied autoreview helper and tests with a shared-installation entrypoint, adds a release note, and updates image-bake documentation. Merge readiness✅ Ready for maintainer review This remains useful work absent from Crabbox main. The prior changelog finding is resolved, the canonical upstream migration is merged, and no blocking introduced defect was identified. Priority: P2 Review scores
Verification
How this fits togetherAutoreview is development tooling that reads a repository’s Git changes and review requirements to produce structured review results. This change moves its implementation into an operator-installed shared skill while retaining Crabbox’s local review policy. flowchart TD
A[Crabbox Git changes] --> D[Shared review helper]
B[Repository entrypoint] --> C[Operator-installed skill]
C --> D
E[Crabbox review requirements] --> D
D --> F[Structured review results]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Maintain one canonical review implementation with thin consumer entrypoints, explicit installation updates, and repository-specific requirements kept local. Do we have a high-confidence way to reproduce the issue? Not applicable: this consolidates development tooling rather than reporting a single runtime bug. Source inspection confirms the bundled copy and its retired scanner prerequisite on main. Is this the best way to solve the issue? Yes. The entrypoint reuses the canonical installer and working-directory-aware helper, avoiding another implementation while preserving local requirements. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f9a122dd96e8. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (2 earlier review cycles) |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
The changelog now includes the PR link and contributor credit. Fresh and forced-upgrade symlink/copy installations passed against the canonical skill. The shared-install cutover is explicitly maintainer-requested.