Repository navigation
chore(autoreview): use the shared canonical skill - #263
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 6, 2026, 2:47 PM ET / 18:47 UTC (Revision 3). ClawSweeper reviewWhat this changesReplaces ClawRouter’s bundled code-review helper and tests with a shared-skill entrypoint, and documents installation, updates, and engine migration. Merge readiness✅ Ready for maintainer review Keep open: current main and v0.4.0 do not implement this consolidation. The latest documentation resolves the earlier migration concerns, and no blocking introduced defect was found. The MEMBER author also excludes automatic closure. Priority: P2 Review scores
Verification
How this fits togetherAutoreview is developer tooling that takes Git changes and repository review requirements into a review engine and returns structured findings. This change delegates that tooling to an operator-installed canonical skill without changing ClawRouter’s request routing. flowchart TD
A[Repository changes] --> B[Local skill entrypoint]
C[Repository review requirements] --> B
B --> D[Shared skill installation]
D --> E[Review engine]
E --> F[Structured findings]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep one operator-managed canonical review installation, preserve local repository requirements, and use the documented migration for existing review commands. Do we have a high-confidence way to reproduce the issue? Not applicable: this is tooling consolidation rather than a single runtime bug. The old bundled path and the canonical installation contract were verified from source. Is this the best way to solve the issue? Yes. Reusing the existing installer and consumer-working-directory behavior removes copied implementations without creating a competing installation mechanism. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e947a93ac20f. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.