Skip to content

fix(ui): persist folder upload input across page refresh #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MunemHashmi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): persist folder upload input across page refresh #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/routes/upload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ export function Upload() {
const [error, setError] = useState<string | null>(null)
const [isDragging, setIsDragging] = useState(false)
const fileInputRef = useRef<HTMLInputElement | null>(null)
const setFileInputRef = (node: HTMLInputElement | null) => {
fileInputRef.current = node
if (node) {
node.setAttribute('webkitdirectory', '')
node.setAttribute('directory', '')
}
}
const validationRef = useRef<HTMLDivElement | null>(null)
const navigate = useNavigate()
const maxBytes = 50 * 1024 * 1024
Expand Down Expand Up @@ -244,11 +251,8 @@ export function Upload() {
requiredFileLabel,
])

useEffect(() => {
if (!fileInputRef.current) return
fileInputRef.current.setAttribute('webkitdirectory', '')
fileInputRef.current.setAttribute('directory', '')
}, [])
// webkitdirectory/directory attributes are set via the ref callback (setFileInputRef)
// to ensure they persist across hydration and re-renders (#58)

if (!isAuthenticated) {
return (
Expand Down Expand Up @@ -416,15 +420,12 @@ export function Upload() {
}}
>
<input
ref={fileInputRef}
ref={setFileInputRef}
className="upload-file-input"
id="upload-files"
data-testid="upload-input"
type="file"
multiple
// @ts-expect-error - non-standard attribute to allow folder selection
webkitdirectory=""
directory=""
onChange={(event) => {
const picked = Array.from(event.target.files ?? [])
void applyExpandedFiles(picked)
Expand Down