fix: increase upload timeout and wrap non-Error abort rejections

[taylorhou]

Problem

Fixes #533

clawhub publish consistently times out with:

✖ Non-error was thrown: "Timeout". You should only throw errors.

Two root causes:

1. Timeout too short for form uploads

REQUEST_TIMEOUT_MS (15s) is applied uniformly to all requests including multipart form uploads in apiRequestForm. Uploading skill files to the server can easily exceed 15s depending on skill size and server-side processing time.

2. Non-Error abort rejections not re-wrapped

In some Node.js/undici versions, controller.abort(reason) causes fetch to reject with the raw reason value rather than wrapping it. If the reason is not an Error instance (or gets lost in propagation), pRetry surfaces the unhelpful Non-error was thrown message instead of the underlying cause.

Fix

1. Added UPLOAD_TIMEOUT_MS = 120_000 (2 min) and applied it to both the Node fetchWithTimeout path and the Bun/curl --max-time path in apiRequestForm / fetchJsonFormViaCurl.
2. In fetchWithTimeout, wrap any non-Error rejection in a new Error so pRetry always receives a proper Error instance.
3. Updated the abort reason message to include the timeout duration for easier debugging.

Testing

Verified locally that clawhub whoami still works and the timeout constants are wired correctly.

[vercel]

Someone is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

Greptile Summary

Increased upload timeout from 15s to 120s and ensured abort rejections are always wrapped in proper Error instances. The changes correctly address the two root causes of clawhub publish timeouts:

• Added UPLOAD_TIMEOUT_MS (120s) constant applied consistently to both Node.js (fetchWithTimeout) and Bun/curl (--max-time) code paths in form upload functions
• Enhanced fetchWithTimeout to wrap non-Error rejections, ensuring pRetry always receives Error instances with meaningful messages
• Improved error messages to include timeout duration for easier debugging

The implementation is clean and follows existing patterns. However, the improved error message format (Request timed out after ${timeoutMs}ms instead of Timeout) will cause test failures in http.test.ts at lines 264 and 346. These test assertions need to be updated to match the new format.

Confidence Score: 4/5

• Safe to merge after updating test assertions to match the new error message format
• The core logic is sound and properly addresses both timeout and error wrapping issues across all code paths. Error handling is defensive and consistent. Score reduced by one point due to breaking test changes - the improved error message breaks exact string assertions in two test cases (lines 264 and 346 in http.test.ts). This is a trivial fix but must be addressed before merge.
• Verify that http.test.ts is updated to match the new timeout error message format before merging

_{Last reviewed commit: 938998d}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Updated timeout error message will break existing tests in http.test.ts (lines 264 and 346) that expect .message to be exactly "Timeout". Update test assertions to match the new format:

Suggested change

	controller.abort(new Error(`Request timed out after ${timeoutMs}ms`))
	controller.abort(new Error(`Request timed out after ${timeoutMs}ms`))

Then update http.test.ts:

// Line 264
expect((caught as Error).message).toContain('timed out')

// Line 346  
expect((caught as Error).message).toContain('timed out')

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/clawdhub/src/http.ts
Line: 220

Comment:
Updated timeout error message will break existing tests in `http.test.ts` (lines 264 and 346) that expect `.message` to be exactly `"Timeout"`. Update test assertions to match the new format:

```suggestion
    controller.abort(new Error(`Request timed out after ${timeoutMs}ms`))
```

Then update `http.test.ts`:
```typescript
// Line 264
expect((caught as Error).message).toContain('timed out')

// Line 346  
expect((caught as Error).message).toContain('timed out')
```

How can I resolve this? If you propose a fix, please make it concise.

[vercel]

Additional Suggestion:

Tests expect error message 'Timeout' but the code produces 'Request timed out after