Repository navigation
chore(autoreview): use the shared canonical skill - #3897
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: blocked before merge. Reviewed October 6, 2026, 1:33 PM ET / 17:33 UTC (Revision 22). ClawSweeper reviewWhat this changesReplace ClawHub’s copied autoreview helper, fixtures, and tests with instructions for using the shared installation, and document the cutover. Merge readiness⛔ Blocked before merge - 3 items remain The consolidation remains useful and is absent from current main. No blocking code finding emerged, but the previously identified review-threshold choice remains unresolved; MEMBER authorship also prevents automatic closure. Priority: P3 Review scores
Verification
How this fits togetherAutoreview checks proposed repository changes before contributor handoff. The repository entrypoint supplies local requirements, while the installed shared helper selects Git changes and returns structured findings. flowchart TD
A[Repository changes] --> B[Local skill entrypoint]
C[Repository requirements] --> B
B --> D[Shared skill installation]
D --> E[Review and severity filtering]
E --> F[Findings and handoff result]
Decision needed
Why: The cutover changes which findings block handoff, and neither local policy nor discussion explicitly approves that narrower threshold. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one upstream implementation and make ClawHub’s chosen handoff threshold explicit, preferably preserving P0–P3 through --max-priority P3. Do we have a high-confidence way to reproduce the issue? Not applicable to a product bug: this is tooling consolidation. Source inspection establishes the old and shared severity behavior without executing either helper. Is this the best way to solve the issue? Yes, sharing the existing installer and helper is the right consolidation boundary. Keeping copied helpers would preserve drift; an explicit local threshold can preserve ClawHub policy without an implementation fork. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 671cd0a0bdcc. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (21 earlier review cycles; latest 8 shown)
|
This comment has been minimized.
This comment has been minimized.
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(autoreview): use the shared canonical skill This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Current-head static, unit, package, type/build, HTTP E2E, Playwright smoke, and every local-auth browser shard passed, including the previously failing generated-card test. The optional Vercel preview deployment failed; its build logs were not available through the installed tooling, so no deployment success is claimed.
Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.