-
-
Notifications
You must be signed in to change notification settings - Fork 731
feat: skill capability visibility, UI badges, and detail page refactor #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orlyjamie
wants to merge
1
commit into
main
Choose a base branch
from
feat/capability-visibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // --------------------------------------------------------------------------- | ||
| // Skill capabilities — shared spec between ClawHub and OpenClaw. | ||
| // | ||
| // KEEP IN SYNC with openclaw/src/agents/skills/types.ts SKILL_CAPABILITIES. | ||
| // | ||
| // These values are validated during skill publish (ClawHub) and at load time | ||
| // (OpenClaw runtime). Both sides must accept the same enum values. | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| export const SKILL_CAPABILITIES = [ | ||
| "shell", // exec, process — run shell commands | ||
| "filesystem", // read, write, edit, apply_patch — file mutations | ||
| "network", // web_search, web_fetch — outbound HTTP | ||
| "browser", // browser — browser automation | ||
| "sessions", // sessions_spawn, sessions_send — cross-session orchestration | ||
| ] as const; | ||
|
|
||
| export type SkillCapability = (typeof SKILL_CAPABILITIES)[number]; | ||
|
|
||
| /** | ||
| * Validate that a list of capability strings are all recognized values. | ||
| * Returns only the valid entries, dropping unknowns silently. | ||
| */ | ||
| export function validateCapabilities(raw: unknown): SkillCapability[] { | ||
| if (!Array.isArray(raw)) { | ||
| return []; | ||
| } | ||
| return raw.filter( | ||
| (v): v is SkillCapability => | ||
| typeof v === "string" && (SKILL_CAPABILITIES as readonly string[]).includes(v), | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Capabilities that should trigger extra moderation review when declared | ||
| * by community (unverified) publishers. | ||
| */ | ||
| export const HIGH_RISK_CAPABILITIES: readonly SkillCapability[] = [ | ||
| "shell", | ||
| "sessions", | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export function SkillCommentsPanel() { | ||
| return <div className="skill-panel"><p style={{ color: 'var(--ink-soft)' }}>Comments not available in dev mode.</p></div> | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as anybypasses type safetyThe
as anycast here silently suppresses any type error if the shape ofresult.latestVersion.parsedchanges. Consider using a narrower cast or adding a typed accessor for the clawdis capabilities, similar to how it's accessed inSkillDetailPage.tsxwith(latestVersion?.parsed as { clawdis?: ClawdisSkillMetadata } | undefined)?.clawdis.Prompt To Fix With AI