Repository navigation
chore(autoreview): use the shared canonical skill - #91
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review in progressClawSweeper is reviewing this revision. This supersedes any previous blocked status. |
|
Codex review: blocked before merge. Reviewed October 5, 2026, 12:51 PM ET / 16:51 UTC (Revision 8). ClawSweeper reviewWhat this changesThe branch replaces Carapace’s copied code-review helper and tests with shared installation guidance and updates the contributor review command. Merge readiness⛔ Blocked before merge - 3 items remain The cutover remains useful because current main still vendors autoreview. No concrete introduced defect was found; the MEMBER-authored PR requires explicit handling of the shared-installation prerequisite. Priority: P3 Review scores
Verification
How this fits togetherAutoreview supports contributor code reviews rather than Carapace’s shipped design assets. The repository supplies Git changes and local requirements to an installed shared helper, which produces structured findings. flowchart TD
A[Contributor changes] --> B[Repository review guidance]
B --> C[Shared skill installation]
C --> D[Review helper]
A --> D
D --> E[Structured findings]
Decision needed
Why: The replacement is technically supported, but readiness for the new operator prerequisite requires repository-owner intent. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one canonical implementation with thin consumer guidance and an explicitly approved, documented installation cutover. Do we have a high-confidence way to reproduce the issue? Not applicable: this is tooling consolidation rather than a reported product bug; source confirms the local command is replaced by an external installation. Is this the best way to solve the issue? Yes, centralizing the existing helper is a focused way to prevent copied implementations from drifting, provided the installation cutover is approved. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 4356b06026d7. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (7 earlier review cycles)
|
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.