Correct module version information#1696
Merged
gregorydlogan merged 2 commits intoopencast:r/18.xfrom Apr 10, 2026
Merged
Conversation
…ific version and taint status as well
|
This pull request is deployed at test.editor.opencast.org/1696/2026-04-09_22-05-23/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new, submodule specific buildnumer and taint status to the built artifact's pom. This is important because otherwise the buildnumber for the submodule(s) does not match the parent pom's, yielding a
Opencast – built on unknownat the bottom of the admin UI. This change uses the parent's buildnumber value in place of the module's normal one, moving the module's into a different field. Note that building the module directly from insidemodules/editordoes not yield the correct buildnumber, instead omitting the value entirely. This is because the child module cannot know the parent's hash. If you as a developer want to have the correct data when building locally, look into maven's-plflag.This comit also fixes a typo related to build profiles.