Color variables everywhere#1623
Open
Arnei wants to merge 8 commits into
Open
Conversation
Touches upon - The "Details >" links in some dialogs - Sub-Header Tabs (e.g. event assets) - Inactive NavBar items (e.g. "Series" when on event page) - Stats Filter - Footer Text
And move relevant css to a more appropriate file.
Only show the "Save" and "Cancel" buttons in the ACL tab if there is something to save or cancel. This is in line with the behaviour of other tabs.
In a further attempt to unify and reduce our color complexity, this patch replaces computed colors with variables and move the color calculations to variables.scss. In some cases it also replaces colors that are only used once in that specific place with a more generally used color.
Replaces a bunch of grey or near-grey colors with suitable alternatives. This constitutes a style change insofar as that some of our grey text or grey borders are now not slightly tinted blue anymore. In my opinion this is not a big loss and even ends up making text easier to read.
Rearranges colors values in the scss file. Gets rid of the "primary-color" naming scheme, as it is unnecessarily wordy for no benefit.
Arnei
added
type:code-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #1618.
This patch aims making colors in our css easier to work with. It does this by
Especially the color reduction results in many subtle color changes all over the UI. They should still overall keep in spirit with the design.
How to test this
Can be tested as is. Check if the UI still looks as expected everywhere.