Skip to content

Fix various color contrast issues #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnei wants to merge 3 commits into
base: r/20.x
Choose a base branch
from
Open

Fix various color contrast issues #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3bd96d
Fix various color contrast issues
Arnei Jun 10, 2026
e4f693c
Remove unnecessary extra file
Arnei Jun 10, 2026
99d3f83
Do not always show "Save" in ACL Tab
Arnei Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/shared/modals/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const Modal = forwardRef<ModalHandle, PropsWithChildren<ModalProps>>(
<div className="modal-animation modal-overlay" />
<section
id={classId}
className={className ? className : "modal wizard modal-animation"}
className={className ? className : "modal modal-animation"}
>
<header>
<ButtonLikeAnchor
Expand Down
2 changes: 1 addition & 1 deletion src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ const ResourceDetailsAccessPolicyTab = ({
}

{/* Save and cancel buttons */}
{!transactions.readOnly && <SaveEditFooter
{!transactions.readOnly && formik.dirty && <SaveEditFooter
active={policyChanged && formik.dirty}
reset={() => resetPolicies(formik.resetForm)}
submit={() => saveAccess(formik.values, false)}
Expand Down
4 changes: 2 additions & 2 deletions src/styles/base/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ $modal-nav-bg-color: #eeeff0;
$modal-nav-border-color: #d6d6d6;
$modal-nav-link-color: #646E75;
$modal-nav-link-active-color: $header-link-color;
$subpage-navigation-link-color: color.adjust($header-link-color, $lightness: 25%); //#fafafa
$subpage-navigation-link-hover-color: color.adjust($header-link-color, $lightness: 35%); //#9cabbc
$subpage-navigation-link-color: $color-silver; //#fafafa
$subpage-navigation-link-hover-color: color.adjust($subpage-navigation-link-color, $lightness: -15%); //#9cabbc

// Stats
// ----------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ $footer-background-color: color.adjust(variables.$body-background, $lightness: -
}

ul li {
color: variables.$light-prim-color;
color: variables.$medium-prim-color;
margin-left: 10px;
vertical-align: top;
font-size: 10px;
Expand Down
2 changes: 2 additions & 0 deletions src/styles/components/modals/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
@include button.btn(green);

&.cancel {
float: left;
margin-left: 3%;
@include button.btn(white);
}

Expand Down
4 changes: 2 additions & 2 deletions src/styles/components/modals/_modal-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
// ----------------------------------------

.details-link {
color: variables.$l-blue;
color: variables.$ref-blue;
white-space: nowrap;
display: flex;
align-items: center;
Expand All @@ -262,7 +262,7 @@
}

&:hover {
color: color.adjust(variables.$l-blue, $lightness: -20%);
color: color.adjust(variables.$ref-blue, $lightness: -20%);
}
}

Expand Down
1 change: 0 additions & 1 deletion src/styles/components/modals/_modals-config.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
@use "_header";
@use "_nav";
@use "_footer";
@use "_wizard";

// Components
@use "_modal-components";
34 changes: 0 additions & 34 deletions src/styles/components/modals/_wizard.scss
View file
Open in desktop

This file was deleted.

Loading