Switch to react-tooltips#1485
Closed
Arnei wants to merge 10000 commits into
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1446.
Replaces our mui tooltip wrapper with react-tooltip. Also adds back tooltips that were commented out.
The reason for this change is that tooltips from react-tooltip are much more performant
when used in larger quantities. It will still add about ~100ms to the render time of events or series
tables with a 100 elements, which is not great but hardly noticable with our load times of over a second.
How to test this
Does not require any special set up for testing. Check that tooltips appear where you expect them and behave as you would expect them to.