Skip to content

Fix language and licence selection in EventDetails tab #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jduehring merged 2 commits into from
Nov 28, 2025
Merged

Fix language and licence selection in EventDetails tab #1479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f8688
fix missing metadata options
Nov 19, 2025
082a6d3
cleanup
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/shared/wizard/RenderField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,15 @@ const EditableSingleSelect = (props: EditableSingleSelectProps) => {
metadataField={metadataField}
text={text}
form={form}
options={
metadataField.collection
? metadataField.collection.map(item => ({
label: item.label ?? item.name,
value: item.value,
order: item.order,
}))
: []
}
Comment on lines +232 to +240
Copy link
Copy Markdown
Contributor

@owi92 owi92 Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also do

Suggested change
options={
metadataField.collection
? metadataField.collection.map(item => ({
label: item.label ?? item.name,
value: item.value,
order: item.order,
}))
: []
}
options={metadataField.collection?.map(option => ({
...option,
label: option.label ?? option.name,
}))}

but it's functionally equivalent, so not super necessary to change.

isFirstField={isFirstField}
focused={focused}
setFocused={setFocused}
Expand Down