Fix OML model compare in Git staging view#15
Open
paulgaspardo wants to merge 2 commits intomasterfrom
Open
Conversation
In the Git staging view, opening a comparison for a changed file would fail with a NullPointerException from trying to read the contents of an IStorage for the "origin" side of the comparison, which doesn't exist. To handle this, instead of using a given IStorage directly, make sure a file for it actually exists by re-loading it from the IStorageProviderAccessor by name.
paulgaspardo
force-pushed
the
fix-git-staging-compare
branch
from
7ec26ba to
3aa2f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Git staging view, opening a comparison for a changed file would fail with a
NullPointerExceptionfrom trying to read the contents of anIStoragefor the "origin" side of the comparison, which doesn't exist.To handle this, instead of using a given
IStoragedirectly, make sure a file for it actually exists by re-loading it from theIStorageProviderAccessorby name.