Skip to content

[bug] fix comment in book.rs #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hunshenshi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bug] fix comment in book.rs #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions programs/openbook-v2/src/state/orderbook/book.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@ impl<'a> Orderbook<'a> {
// generate new order id
let order_id = market.gen_order_id(side, price_data);

// Iterate through book and match against this new order.
//
// Any changes to matching orders on the other side of the book are collected in
// matched_changes/matched_deletes and then applied after this loop.

let order_max_base_lots = order.max_base_lots;
let order_max_quote_lots = if side == Side::Bid && !post_only {
market.subtract_taker_fees(order.max_quote_lots_including_fees)
Expand All @@ -115,6 +110,10 @@ impl<'a> Orderbook<'a> {
let mut referrer_amount = 0_u64;
let mut maker_rebates_acc = 0_u64;

// Iterate through book and match against this new order.
//
// Any changes to matching orders on the other side of the book are collected in
// matched_order_changes/matched_order_deletes and then applied after this loop.
let mut matched_order_changes: Vec<(BookSideOrderHandle, i64)> = vec![];
let mut matched_order_deletes: Vec<(BookSideOrderTree, u128)> = vec![];
let mut number_of_dropped_expired_orders = 0;
Expand Down