feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings#268
Open
wiseaidev wants to merge 1 commit intoopenbook-dex:masterfrom
Open
feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings#268wiseaidev wants to merge 1 commit intoopenbook-dex:masterfrom
wiseaidev wants to merge 1 commit intoopenbook-dex:masterfrom
Conversation
Contributor
|
the retry mechanism is not reactive to error codes: a 429 can be retried, but all other errors should probably be exposed to the user immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested these changes locally yet, but should work. Let's try it on CI. This PR contains the following changes:
Async traits have been stabilized and are part of the language since version 1.75: https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.htmlbincodecrate and usedserde_jsoninsteadbackon: https://docs.rs/backon