Skip to content

feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings#268

Open
wiseaidev wants to merge 1 commit intoopenbook-dex:masterfrom
wiseaidev:cleanup
Open

feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings#268
wiseaidev wants to merge 1 commit intoopenbook-dex:masterfrom
wiseaidev:cleanup

Conversation

@wiseaidev
Copy link
Contributor

@wiseaidev wiseaidev commented Jun 3, 2024

I haven't tested these changes locally yet, but should work. Let's try it on CI. This PR contains the following changes:

@wiseaidev wiseaidev changed the title feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings, upgrade to rust 1.75+ feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings Jun 5, 2024
@mschneider
Copy link
Contributor

the retry mechanism is not reactive to error codes: a 429 can be retried, but all other errors should probably be exposed to the user immediately.
apart from that i would prefer if the retry was implemented outside the core client library functions, if users want to use their own logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants