Repository navigation
ci: pin runner images so the matrix can actually run - #1206
Merged
Merged
Conversation
- macos-12 is retired, so its job queued forever; use macos-15 - ubuntu-latest is Ubuntu 26.04 now, where setup-python has no 3.8 build; pin Ubuntu to 24.04, which still ships one - give every matrix entry an explicit python-version (the macOS job had none and ran as "macOS /") - upgrade checkout/setup-python/codecov actions; drop the deprecated codecov/test-results-action that never found any JUnit report - add timeout, concurrency and a nightly cron so future runner or Python build removals surface on master instead of blocking the next PR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 45.26% 45.26%
=======================================
Files 29 29
Lines 4158 4158
Branches 812 812
=======================================
Hits 1882 1882
Misses 2164 2164
Partials 112 112 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The workflow has been quietly broken since GitHub moved its hosted runner images. This is why #1205 looked half-red/half-stuck even though the change was fine:
macos-12is retired → the macOS job queues forever, it never picks up a runner.ubuntu-latestnow resolves to Ubuntu 26.04, whereactions/setup-pythonhas no Python 3.8 build →The version '3.8' with architecture 'x64' was not found for Ubuntu 26.04before any test runs.includewithoutpython-version, so it runs with an empty version — that is why the job is calledmacOS /.Python applicationrun on master was on Nov 2, so the next PR was the first thing to trip over it.Fix
macos-12→macos-15(with Python 3.11; 3.8 has no macOS arm64 build).ubuntu-24.04instead ofubuntu-latest, which still ships Python 3.8, so no supported version is dropped from the matrix.includeentries that each carrypython-version, so${{ matrix.python-version }}is never empty.actions/checkout@v7,actions/setup-python@v7,codecov/codecov-action@v7; dropcodecov/test-results-action@v1— it is deprecated and reportedFound 0 test_results fileson every run.timeout-minutes: 20, PRconcurrencycancellation, and a nightly cron on master. A future runner or Python build removal then fails loudly overnight instead of blocking the next PR.Verification
This PR's own checks exercise the new matrix:
Ubuntu / 3.8,Ubuntu / 3.11,Windows / 3.8,Windows / 3.11,macOS / 3.11.Overlaps with #1204 (runner + action upgrades). Either can land; this one also keeps Python 3.8 coverage and fixes the empty matrix entry.