Repository navigation
fix: reject non-object JSON responses in the u2cli client - #1200
Merged
codeskyblue merged 1 commit intoOct 18, 2026
Merged
codeskyblue merged 1 commit into
codeskyblue merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client parses JSON responses and then calls
.get()on the decoded value. A response such as[],null, or a string therefore raisesAttributeError, bypassing theU2CliErrorhandling inis_running().Validate that the response envelope is a JSON object before accessing its fields. Invalid envelopes raise
U2CliError, andis_running()returns false. Valid envelopes can still contain results of any JSON type; remote error handling is unchanged.Validation on macOS with Python 3.12.15:
Android device tests and the cross-platform CI matrix were not run locally.