Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi-react-query): support for useInfiniteQuery() #2117

Merged
merged 10 commits into from
Jan 25, 2025

Conversation

lukasedw
Copy link
Contributor

Changes

close #1828

I added useInfiniteQuery() to openapi-react-query.

How to Review

Any feedback is welcome. I'll review it and make updates!

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

This is a continuation work of #1881

@lukasedw lukasedw requested a review from a team as a code owner January 24, 2025 21:50
@lukasedw lukasedw requested a review from drwpow January 24, 2025 21:50
Copy link

netlify bot commented Jan 24, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bb9b4ad

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: bb9b4ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-react-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasedw
Copy link
Contributor Author

May I have some reviews, please? @HagenMorano @kerwanp @drwpow @tommymarshall

@lukasedw lukasedw changed the title Feat/use infinite query feat(openapi-react-query): support for useInfiniteQuery() Jan 24, 2025
@lukasedw lukasedw requested a review from musjj January 25, 2025 19:12
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great. If you could just rebase off main I’d be happy to merge & release this.

@lukasedw lukasedw force-pushed the feat/useInfiniteQuery branch from 0b7e226 to bb9b4ad Compare January 25, 2025 19:29
@lukasedw
Copy link
Contributor Author

I just realized I should branched off #1881, but I was not going to do a PR, but I did haha.
Rebase done @drwpow!

@lukasedw lukasedw requested a review from drwpow January 25, 2025 19:33
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@drwpow drwpow merged commit 3ef38b8 into openapi-ts:main Jan 25, 2025
8 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openapi-react-query: support for useInfiniteQuery()
3 participants