Add schema to postTransform options#2049
Merged
drwpow merged 4 commits intoopenapi-ts:mainfrom Jan 3, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: aba4e09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
duncanbeevers
force-pushed
the
posttransform-options-schema
branch
from
9f5c655 to
be8de00
Compare
drwpow
approved these changes
Jan 3, 2025
Contributor
drwpow
left a comment
drwpow
left a comment
There was a problem hiding this comment.
Great code, great docs, and great tests! I don’t have any feedback
duncanbeevers
added a commit
to duncanbeevers/openapi-typescript
that referenced
this pull request
Jan 3, 2025
* Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options
drwpow
added a commit
that referenced
this pull request
Jan 4, 2025
* Add schema to postTransform options (#2049) * Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options * Add Netlify badge (#2065) * Only check GitHub token for docs build when update needed * Add Netlify badge * Use link * [ci] release (#2084) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix issue templates (#2088) * Add feat issues to projects (#2090) * Use const arrays for OpenAPI enum types Preserve capitalization of named, exported enum values. Type exported const values as const, instead of their location within the operations or components schemas. Derive and export types for enum values from concrete values in const arrays. Use derived enum value types in operations and components schemas. Use non-conflicting variable names for composed OpenAPI enums (anyOf: [enum1, enum2]) * Export type-predicates along when enumValues is true --------- Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: openapi-ts-bot <openapi-ts@googlegroups.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2013
Changes
schematopostTransformoptionspostTransformoptionsschemaoption to declare a string SetHow to Review
TransformNodeOptionsis extension is acceptable.schemashould be populated fortransformoptions; it's redundant since the first argument to transform is already the schema node, but it introduces consistency between thetransformandpostTrannsformAPIs that I think might be desirable.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript) (I tried this and got swamped with changes, please advise!)