fix: log only metadata for Live WebSocket diagnostics - #3865
Conversation
Use message sizes and generic connection and queue warnings across Live, forks, and sideband. Extend the existing sync and async logging tests.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 45 mixed files remain; 3 existing customizations changed. Compared
42 existing customizations unchanged
2 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35016963532 --repo openai/openai-python \
--name castiron-custom-code-35016963532-1 --dir /tmp/castiron-custom-code-35016963532-1
git apply --stat /tmp/castiron-custom-code-35016963532-1/custom-code.patch
cat /tmp/castiron-custom-code-35016963532-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9640f2903d65c43f0e5aee58d60f46880ff0bd15 a1b1b1b40b5888c7e2a99301a96c4ef5daaf8357
python3 scripts/castiron/custom_code_report.py report \
--base 9640f2903d65c43f0e5aee58d60f46880ff0bd15 \
--head a1b1b1b40b5888c7e2a99301a96c4ef5daaf8357 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a1b1b1b40b58
cat /tmp/castiron-custom-code-a1b1b1b40b58/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed all six sync/async paths across Live, forks, and sideband plus the expanded shared logging matrix. The change removes payload bytes, URL/query values, connection-option contents, and exception text from logs while retaining useful message-size and generic lifecycle/queue diagnostics. recv(decode=False) provides bytes for the length log, runtime connection/send behavior is untouched, and coverage exercises parsed/raw receives, connection metadata, and queue failures for every applicable surface. Automated code/security reviews and the completed static checks are clean; no blocking issues found.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the sync and async Live, Forks, and Sideband receive, connection, and queue-failure paths. The metadata-only messages match the existing SDK convention, and the shared tests retain checks that actual payloads and connection options still reach their consumers. No consequential findings. The production AST is unchanged after removing logging statements, and this stays within the existing implementation without adding an abstraction.
Validation: 121 focused logging, queue, reconnect, and connection-option tests passed locally. An independent 18-case probe, with 18 exact-base controls, checked raw log records, payload/credential delivery, and partial queue-failure ordering and retry behavior. Repository CI passed on Python 3.10/3.14 and HTTPX2 with both Pydantic versions; lint and package builds passed.
The separate OkTest report remains 234/236: two Responses stream tests reject the observed Connection error. text. Those are validation failures outside the changed Live paths, not findings against this patch. No live API/WebSocket validation was performed; the local environment used Pydantic 2.
Automated Release PR --- ## [3.14.1](openai/openai-python@v3.14.0...v3.14.1) (2026-09-15) ### Bug Fixes * **client:** validate retry limits and preserve application errors ([openai#3867](openai#3867)) ([f86c721](openai@f86c721)) * correct typo "th" to "the" in StreamAlreadyConsumed error message ([openai#3022](openai#3022)) ([7186203](openai@7186203)) * **examples:** correct Azure endpoint hostname ([openai#3298](openai#3298)) ([543516c](openai@543516c)) * **examples:** refresh chat streaming examples ([openai#2974](openai#2974)) ([54f460e](openai@54f460e)) * **examples:** split push-to-talk shebang arguments ([openai#3210](openai#3210)) ([d241ed6](openai@d241ed6)) * **examples:** use uv in remaining Python launchers ([openai#3821](openai#3821)) ([8c76c4f](openai@8c76c4f)) * log only metadata for Live WebSocket diagnostics ([openai#3865](openai#3865)) ([ccc10f5](openai@ccc10f5)) * **responses:** skip structured parsing for commentary ([openai#3861](openai#3861)) ([6520df1](openai@6520df1)) ### Chores * **examples:** bump module_client.py to gpt-5.6 ([openai#3211](openai#3211)) ([1493321](openai@1493321)) * remove unused fine-tuning data validators ([openai#3863](openai#3863)) ([9640f29](openai@9640f29)) ### Documentation * clarify async client cleanup ([openai#2388](openai#2388)) ([a3d83b5](openai@a3d83b5)) * clarify filenames for in-memory file uploads ([openai#3729](openai#3729)) ([cb27380](openai@cb27380)) * **client:** correct retry jitter comment ([openai#2252](openai#2252)) ([bdbbc16](openai@bdbbc16)) * fix Realtime docstring wording ([openai#3535](openai#3535)) ([8cb9ded](openai@8cb9ded)) * fix reusing wording in Azure client docstrings ([openai#3061](openai#3061)) ([dc625f9](openai@dc625f9)) * fix streaming comment typo ([openai#3005](openai#3005)) ([d421d7a](openai@d421d7a)) * fix vector store polling helper paths ([openai#3101](openai#3101)) ([2ef2de6](openai@2ef2de6)) * **readme:** correct SSE terminology ([openai#2837](openai#2837)) ([caaa9b4](openai@caaa9b4)) * update Responses API reference link ([openai#3279](openai#3279)) ([557bd06](openai@557bd06)) * **utils:** correct query component RFC reference ([openai#3300](openai#3300)) ([929a8a5](openai@929a8a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
3 participants
Aligns Live, forks, and sideband WebSocket diagnostics with the existing SDK logging pattern: message sizes and generic connection and queue-warning messages. Extends sync and async logging coverage.
Validation: 460 related tests passed, plus 84 logging tests with Pydantic v1. Ruff, mypy, changed-file formatting, and wheel/sdist builds pass.