test(scan): exercise large git output on Windows - #614
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e75024e602
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Stacked follow-up to #572, which fixes committed-diff scan preparation when the tracked-file inventory exceeds Node's default subprocess buffer. This keeps its regression coverage active on Windows. Merge #572 first, then refresh this branch against
main.Changes
git ls-files -t -zoutput without overlong Windows pathsTesting
Run from
sdk/typescriptunless noted otherwise:corepack pnpm dlx bun@1.3.14 test --timeout 30000 tests-ts/targets-large-output.test.ts --seed 12345(1 passed)corepack pnpm dlx bun@1.3.14 test --timeout 30000 ./tests-ts --seed 12345(1,436 passed, 23 platform-specific skips; one unrelated concurrency assertion failed and passed on immediate isolated rerun)corepack pnpm dlx bun@1.3.14 test --timeout 30000 tests-ts/api-credentials.test.ts --seed 12345 -t 'runs parallel ChatGPT scans with isolated mutable configuration'(1 passed)corepack pnpm run types,corepack pnpm run format,corepack pnpm run build, andgit diff --check(passed)Risk and rollout
Test-only follow-up. The regression creates 6,000 temporary empty files and removes its temporary repository after each run. It does not change runtime behavior or public CLI surface. Until #572 merges, GitHub's comparison against
mainalso includes the parent pull request's commits.Public disclosure review