-
-
Notifications
You must be signed in to change notification settings - Fork 587
feat: add OpenAI compatibility support for Google Gemini #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OpenAI compatibility support for Google Gemini #502
Conversation
Any chance to get this rolling? :) |
Hello. Thank you for this PR any news on it ? |
hello. any plan to merge this PR? |
btw, here's my temporary fixed. |
Would be great to merge this, as this bug currently completely prevents using Gemini models with the SDK! :) |
Sorry for delay on this. At the moment there are conflicts, so those would need to be resolved so we can confirm if CI passes, then I can take a look and review this. |
…ility-support-for-gemini
It looks good! Just a thought about 1 thing. If we have people depending on this package and the Do we think thats alright? My only other thought is to dynamically create some random index since it seems Gemini does not if we don't have one in the response. The downside to that is folks may store an ID thinking its from Gemini and its instead some made up value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think nullable is right call vs a fake index. It reflects how the official SDKs degrade
thanks! |
What:
Description:
According to the Google Gemini OpenAI compatibility documentation, OpenAI's official Python and Node.js SDKs are supported for compatibility.
Hope that the PHP version can also be updated to reflect this compatibility :)
Related:
https://ai.google.dev/gemini-api/docs/openai
fixes: #526