Skip to content

Fix UI freeze when discarding changes caused by async MQTT state #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brett-S-OWB wants to merge 5 commits into
base: main
Choose a base branch
from
+21 −15
Open

Fix UI freeze when discarding changes caused by async MQTT state #891

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc93300
filter vehicle templates - prevent async error
Brett-S-OWB Jan 26, 2026
7f7867a
filter ev / charge templates as objects
Brett-S-OWB Jan 26, 2026
6153625
optional chaining for vehicle card inputs
Brett-S-OWB Jan 26, 2026
7c9d9b1
formatting
Brett-S-OWB Jan 26, 2026
796980c
add comments
Brett-S-OWB Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions src/views/VehicleConfig.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@
<openwb-base-text-input
v-if="vehicleId !== 0"
title="Fahrzeughersteller "
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/info'].manufacturer"
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/info']?.manufacturer"
@update:model-value="updateState('openWB/vehicle/' + vehicleId + '/info', $event, 'manufacturer')"
>
<template #help> Optional: zusätzliche Information für den Systembericht. </template>
</openwb-base-text-input>
<openwb-base-text-input
v-if="vehicleId !== 0"
title="Fahrzeugmodell"
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/info'].model"
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/info']?.model"
@update:model-value="updateState('openWB/vehicle/' + vehicleId + '/info', $event, 'model')"
>
<template #help>
Expand Down Expand Up @@ -132,7 +132,7 @@
<hr />
<div v-if="!installAssistantActive">
<openwb-base-heading> Fahrzeugzuordnung per ID-Tags </openwb-base-heading>
<div v-if="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/tag_id'].length > 0">
<div v-if="($store.state.mqtt['openWB/vehicle/' + vehicleId + '/tag_id']?.length ?? 0) > 0">
<openwb-base-alert subtype="info">
Einstellungen zur Fahrzeugzuordnung finden sich unter
<router-link to="/IdentificationConfig"> Einstellungen - Identifikation </router-link>.
Expand Down Expand Up @@ -169,7 +169,7 @@
class="mb-2"
title="SoC-Modul des Fahrzeugs"
:options="socModuleList"
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/config'].type"
:model-value="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/config']?.type"
@update:model-value="updateSelectedSocModule(vehicleId, $event)"
>
<template #help>
Expand All @@ -189,7 +189,7 @@
infolge von zeitlicher Verzögerungen kommen. Hilfestellung erfolgt primär im openWB-Forum.
</template>
</openwb-base-select-input>
<div v-if="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/config'].type">
<div v-if="$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/config']?.type">
<openwb-base-button-group-input
title="SoC direkt aus Fahrzeug auslesen"
:buttons="[
Expand All @@ -205,7 +205,7 @@
},
]"
:model-value="
$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/general_config'].use_soc_from_cp
$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/general_config']?.use_soc_from_cp
"
@update:model-value="
updateState('openWB/vehicle/' + vehicleId + '/soc_module/general_config', $event, 'use_soc_from_cp')
Expand Down Expand Up @@ -233,7 +233,7 @@
required
:model-value="
$store.state.mqtt['openWB/vehicle/' + vehicleId + '/soc_module/general_config']
.request_interval_charging / 60
?.request_interval_charging / 60
"
@update:model-value="
updateState(
Expand Down Expand Up @@ -1484,10 +1484,13 @@ export default {
return this.getWildcardIndexList("openWB/vehicle/+/name");
},
},
evTemplates: {
get() {
return this.getWildcardTopics("openWB/vehicle/template/ev_template/+");
},
evTemplates() {
const evTemplates = this.getWildcardTopics("openWB/vehicle/template/ev_template/+");
return Object.fromEntries(
// Filter out temporarily undefined entries caused by async MQTT (unsubscribe/resubscribe),
// (on button push, discard changes) so templates never try to render incomplete data.
Object.entries(evTemplates).filter(([, template]) => template && typeof template === "object"),
);
},
evTemplateList: {
get() {
Expand All @@ -1500,10 +1503,13 @@ export default {
return myList;
},
},
chargeTemplates: {
get() {
return this.getWildcardTopics("openWB/vehicle/template/charge_template/+");
},
chargeTemplates() {
const chargeTemplates = this.getWildcardTopics("openWB/vehicle/template/charge_template/+");
return Object.fromEntries(
// Filter out temporarily undefined entries caused by async MQTT (unsubscribe/resubscribe),
// (on button push, discard changes) so templates never try to render incomplete data.
Object.entries(chargeTemplates).filter(([, template]) => template && typeof template === "object"),
);
},
chargeTemplateList: {
get() {
Expand Down
Loading