Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds middleware to two endpoints as examples:
jsonResponseHeaders
: Adds content-type headers to all responsejwtAuth
: Finds and extracts the jwt from a request to check if there is a valid user authentication. The user is provided in the context for endpoints to be used.Overall, with middleware being an unstable feature still, it seems to be a bit tricky to get the right typings for it..
A bit annoying but powerful.
The tests need to be adjusted a bit to make use of the middleware, because the current scheme only runs the loader/action functions directly, skipping over the middleware. Technically thats the better unit test and middleware functions could be tested separately. I think I prefer that, what do you think?