-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/download function #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
* fetching data for download * modified * updated * updates * working Download Code
…Map/frontend into feat/download-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress so far!
I noticed a couple of small things in the code itself, please address those.
A couple more things to consider:
- I think all the new stuff we add should be in german and english straight away. For that reason you should add the translation function to your newly added strings
- May I recommend to refactor the action a little bit: Move the individual file formats into their own functions to prevent getting spaghetti code and increase reusability. E.g. one function for csv, one for json, etc. and then just call those in the action. Makes it way more readable :-)
- Why do I need to click the "download" button after the preparation is done? Can't this just start automatically? Would make it more user friendly in my opinion. Also can we add a note to not close the modal during the process or otherwise the download will be interrupted?
- If you are interested in fiddling around with performance improvements, we can have a chat about parallelizing some promises, specifically for accessing the measurements. A couple of lines including
Promise.all
could help speed up things for the user. Just let me know.
…Map/frontend into feat/download-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some ESLint warnings as far as I can tell.
I left two small things I found as well.
You could further increase the readability of your action by taking out the functions that generate each individual file format to a different place in the code. This way it is taken out from the reading flow.
One option would be to move it to a new file like file-exports.ts
in the utils folder.
Modified download feature.