Skip to content

Write scientific defaults upon close (Iteration::close or Series::close) #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franzpoeschel wants to merge 89 commits into
base: dev
Choose a base branch
from

Fix dirty handling

8d5fb44
Select commit
Loading
Failed to load commit list.
Open

Write scientific defaults upon close (Iteration::close or Series::close) #1834

Fix dirty handling
8d5fb44
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Apr 30, 2026 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 11 in include/openPMD/backend/scientific_defaults/ProcessParsedAttribute.tpp

See this annotation in the file changed.

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
Mesh
Loading
is 112 bytes - consider passing a const pointer/reference instead.

Check notice on line 284 in src/Mesh.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 538 in src/RecordComponent.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
RecordComponent
Loading
is 72 bytes - consider passing a const pointer/reference instead.

Check notice on line 701 in test/CoreTest.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.