Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.71.0 to 1.71.2 #1851

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 5, 2025

Bumps rubocop from 1.71.0 to 1.71.2.

Release notes

Sourced from rubocop's releases.

RuboCop 1.71.2

Bug fixes

  • #13782: Fix an error Layout/ElseAlignment when else is part of a numblock. (@​earlopain)
  • #13395: Fix a false positive for Lint/UselessAssignment when assigning in branch and block. (@​pCosta99)
  • #13783: Fix a false positive for Lint/Void when each numblock with conditional expressions that has multiple statements. (@​earlopain)
  • #13787: Fix incorrect autocorrect for Style/ExplicitBlockArgument when using arguments of zsuper in method definition. (@​koic)
  • #13785: Fix Style/EachWithObject cop error in case of single block argument. (@​viralpraxis)
  • #13781: Fix a false positive for Lint/UnmodifiedReduceAccumulator when omitting the accumulator in a nested numblock. (@​earlopain)

RuboCop 1.71.1

Bug fixes

  • #10081: Add the missing include RuboCop::RSpec::ExpectOffense in rubocop/rspec/support.rb. (@​d4rky-pl)
  • #13765: Fix a false negative for Lint/AmbiguousBlockAssociation with numblocks. (@​earlopain)
  • #13759: Fix a false negative for Lint/ConstantDefinitionInBlock with numblocks. (@​earlopain)
  • #13741: Register an offense for Naming/BlockForwarding and Style/ArgumentsForwarding with Ruby >= 3.4 when the block argument is referenced inside a block. This was previously disabled because of a bug in Ruby 3.3.0. (@​earlopain)
  • #13777: Fix a false negative for Layout/EmptyLineBetweenDefs with DefLikeMacros and numblocks. (@​earlopain)
  • #13769: Fix a false negative for Style/RedundantParentheses with numblocks. (@​earlopain)
  • #13780: Fix a false positive Style/AccessModifierDeclarations when using access modifier in a numblock. (@​earlopain)
  • #13775: Fix a false positive for Lint/AssignmentInCondition when assigning in numblocks. (@​earlopain)
  • #13773: Fix false positives for Layout/RedundantLineBreak when using numbered block parameter. (@​koic)
  • #13761: Fix a false positive for Style/SuperArguments when calling super in a numblock. (@​earlopain)
  • #13768: Fix a false positive for Lint/UnreachableCode with instance_eval numblock. (@​earlopain)
  • #13750: Fix false positives for Style/RedundantSelfAssignment when assigning to attribute of self. (@​koic)
  • #13739: Fix false positive for Style/HashExcept and Style/HashSlice when checking for inclusion with a range. (@​dvandersluis)
  • #13751: Fix false positive in Layout/ExtraSpacing with ForceEqualSignAlignment: true for endless methods. (@​dvandersluis)
  • #13767: Fix Style/IdenticalConditionalBranches autocorrect when condition is inside assignment. (@​dvandersluis)
  • #13764: Fix a false negative for Layout/SingleLineBlockChain with numblocks. (@​earlopain)
  • #13771: Fix wrong autocorrect for Style/SoleNestedConditional when using numblocks. (@​earlopain)
Changelog

Sourced from rubocop's changelog.

1.71.2 (2025-02-04)

Bug fixes

  • #13782: Fix an error Layout/ElseAlignment when else is part of a numblock. ([@​earlopain][])
  • #13395: Fix a false positive for Lint/UselessAssignment when assigning in branch and block. ([@​pCosta99][])
  • #13783: Fix a false positive for Lint/Void when each numblock with conditional expressions that has multiple statements. ([@​earlopain][])
  • #13787: Fix incorrect autocorrect for Style/ExplicitBlockArgument when using arguments of zsuper in method definition. ([@​koic][])
  • #13785: Fix Style/EachWithObject cop error in case of single block argument. ([@​viralpraxis][])
  • #13781: Fix a false positive for Lint/UnmodifiedReduceAccumulator when omitting the accumulator in a nested numblock. ([@​earlopain][])

1.71.1 (2025-01-31)

Bug fixes

  • #10081: Add the missing include RuboCop::RSpec::ExpectOffense in rubocop/rspec/support.rb. ([@​d4rky-pl][])
  • #13765: Fix a false negative for Lint/AmbiguousBlockAssociation with numblocks. ([@​earlopain][])
  • #13759: Fix a false negative for Lint/ConstantDefinitionInBlock with numblocks. ([@​earlopain][])
  • #13741: Register an offense for Naming/BlockForwarding and Style/ArgumentsForwarding with Ruby >= 3.4 when the block argument is referenced inside a block. This was previously disabled because of a bug in Ruby 3.3.0. ([@​earlopain][])
  • #13777: Fix a false negative for Layout/EmptyLineBetweenDefs with DefLikeMacros and numblocks. ([@​earlopain][])
  • #13769: Fix a false negative for Style/RedundantParentheses with numblocks. ([@​earlopain][])
  • #13780: Fix a false positive Style/AccessModifierDeclarations when using access modifier in a numblock. ([@​earlopain][])
  • #13775: Fix a false positive for Lint/AssignmentInCondition when assigning in numblocks. ([@​earlopain][])
  • #13773: Fix false positives for Layout/RedundantLineBreak when using numbered block parameter. ([@​koic][])
  • #13761: Fix a false positive for Style/SuperArguments when calling super in a numblock. ([@​earlopain][])
  • #13768: Fix a false positive for Lint/UnreachableCode with instance_eval numblock. ([@​earlopain][])
  • #13750: Fix false positives for Style/RedundantSelfAssignment when assigning to attribute of self. ([@​koic][])
  • #13739: Fix false positive for Style/HashExcept and Style/HashSlice when checking for inclusion with a range. ([@​dvandersluis][])
  • #13751: Fix false positive in Layout/ExtraSpacing with ForceEqualSignAlignment: true for endless methods. ([@​dvandersluis][])
  • #13767: Fix Style/IdenticalConditionalBranches autocorrect when condition is inside assignment. ([@​dvandersluis][])
  • #13764: Fix a false negative for Layout/SingleLineBlockChain with numblocks. ([@​earlopain][])
  • #13771: Fix wrong autocorrect for Style/SoleNestedConditional when using numblocks. ([@​earlopain][])
Commits
  • 2cd0ca2 Cut 1.71.2
  • b205529 Update Changelog
  • da31e5a Merge pull request #13785 from viralpraxis/fix-style-each-with-object-cop-err...
  • b3e86f6 Fix Style/EachWithObject cop error in case if single block argument
  • 7e0ffa0 [Fix #13787] Fix incorrect autocorrect for Style/ExplicitBlockArgument
  • 910795c Merge pull request #13409 from pCosta99/issue/13395
  • 0d8d9ed Merge pull request #13784 from koic/stablize_help_command_line_option_test
  • 8c1dc79 Stabilize help command line option test
  • 933c879 Merge pull request #13783 from Earlopain/lint-void-numblock
  • 8a48e61 Merge pull request #13782 from Earlopain/else-alignment-numblock
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @openhpi-bot.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Feb 5, 2025
Copy link

@openhpi-bot openhpi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2025

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.71.0 to 1.71.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.71.0...v1.71.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.71.2 branch from 427e0ab to b7b477b Compare February 7, 2025 03:14
Copy link

@openhpi-bot openhpi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot merged commit b6e2b06 into main Feb 7, 2025
8 checks passed
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.71.2 branch February 7, 2025 21:56
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.79%. Comparing base (e1b9021) to head (1d82c7e).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
app/helpers/application_helper.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files         133      133           
  Lines        3345     3345           
=======================================
  Hits         3171     3171           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants