refactor(enmeshed): Move serialization for creating IdentityAttribute…

…s to `Attribute::Identity` The former implementation of `Attibute.to_json` was very specific to IdentityAttributes. It actually only worked for simple IdentityAttributes and would need adaptations for complex IdentityAttributes. Part of XI-6523
openHPI · Feb 5, 2025 · 68ddf44 · 68ddf44
1 parent 5dad0f5
commit 68ddf44
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/lib/enmeshed/attribute.rb b/lib/enmeshed/attribute.rb
@@ -32,21 +32,14 @@ def self.parse(content)
       desired_klass.new(**attributes.compact)
     end
 
+    # Serialize all available attributes of an Attribute object.
+    # E.g. for sharing it when making the API request to create a relationship template.
+    #
+    # @return [Hash]
     def to_h
       default_attributes.deep_merge(additional_attributes)
     end
 
-    def to_json(*)
-      {
-        content: {
-          value: {
-            '@type': @type,
-            value: @value,
-          },
-        },
-      }.to_json(*)
-    end
-
     def id
       @id ||= persistent_id
     end

diff --git a/lib/enmeshed/attribute/identity.rb b/lib/enmeshed/attribute/identity.rb
@@ -2,6 +2,22 @@
 
 module Enmeshed
   class Attribute::Identity < Attribute
+
+    # Serialize the Identity object to fit the content requirements when creating
+    # an IdentityAttribute via the Connector API (available under Connector::CONNECTOR_URL)
+    #
+    # @return [String] JSON
+    def to_json(*)
+      {
+        content: {
+          value: {
+            '@type': @type,
+            value: @value,
+          },
+        },
+      }.to_json(*)
+    end
+
     private
 
     def additional_attributes