Skip to content

Avoid printing to stdout in DSP code #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drobilla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid printing to stdout in DSP code #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions dsp/fabla.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ instantiate(const LV2_Descriptor* descriptor,
if ( self->log )
lv2_log_warning(&self->logger, "Fabla: Warning, your host doesn't support the Worker extension. Loading samples may cause Xruns!");
else
printf("Fabla: Warning, your host doesn't support the Worker extension. Loading samples may cause Xruns!");
fprintf(stderr, "Fabla: Warning, your host doesn't support the Worker extension. Loading samples may cause Xruns!");
}

// initialize master output smoothing state
Expand Down Expand Up @@ -363,7 +363,7 @@ connect_port(LV2_Handle instance,
break;

default:
printf("Error: Attempted connect of non-existing port with ID %u \n", port); break;
fprintf(stderr, "Error: Attempted connect of non-existing port with ID %u \n", port); break;
}
}

Expand Down Expand Up @@ -816,7 +816,7 @@ work(LV2_Handle instance,
uint32_t size,
const void* data)
{
printf("Fabla: Work() now\n" );
fprintf(stderr, "Fabla: Work() now\n" );
FABLA_DSP* self = (FABLA_DSP*)instance;
LV2_Atom* atom = (LV2_Atom*)data;

Expand All @@ -829,18 +829,18 @@ work(LV2_Handle instance,
}
else
{
printf("Fabla Work() LoadSample type message\n" );
fprintf(stderr, "Fabla Work() LoadSample type message\n" );
/* Handle set message (load sample). */
LV2_Atom_Object* obj = (LV2_Atom_Object*)data;

printf("Fabla Work() LV2_Atom_Object atom type %i, body.otype %i \n", obj->atom.type, obj->body.otype );
fprintf(stderr, "Fabla Work() LV2_Atom_Object atom type %i, body.otype %i \n", obj->atom.type, obj->body.otype );

/* Get file path from message */
const LV2_Atom_Int* sampleNum = 0;// FIXME read_set_file_sample_number(&self->uris, obj);

if ( !sampleNum )
{
printf("Fabla Work() LoadSample Sample number not found in Atom\n" );
fprintf(stderr, "Fabla Work() LoadSample Sample number not found in Atom\n" );
}
else
{
Expand All @@ -849,7 +849,7 @@ work(LV2_Handle instance,

const LV2_Atom* file_path = 0; //fixme: take from Atom message
if (!file_path) {
printf( "Fabla Work() LoadSample FILE PATH NOT VALID\n" );
fprintf(stderr, "Fabla Work() LoadSample FILE PATH NOT VALID\n" );
return LV2_WORKER_ERR_UNKNOWN;
}

Expand Down Expand Up @@ -961,7 +961,7 @@ save(LV2_Handle instance,

if ( !map_path )
{
printf("Error: map path not available! SAVE DID NOT COMPLETE!\n" );
fprintf(stderr, "Error: map path not available! SAVE DID NOT COMPLETE!\n" );
return LV2_STATE_ERR_NO_FEATURE;
}

Expand All @@ -977,7 +977,7 @@ save(LV2_Handle instance,

if ( apath )
{
printf("Storing on pad %i, apath %s\n", i, apath );
fprintf(stderr, "Storing on pad %i, apath %s\n", i, apath );
store(handle,
self->uris->padFilename[i],
apath,
Expand All @@ -989,7 +989,7 @@ save(LV2_Handle instance,
}
else
{
printf("apath = null on pad %i\n", i );
fprintf(stderr, "apath = null on pad %i\n", i );
}
}
}
Expand Down Expand Up @@ -1035,13 +1035,13 @@ restore(LV2_Handle instance,
}
else
{
printf("Error: load_sample() return zero on pad %i\n", i);
fprintf(stderr, "Error: load_sample() return zero on pad %i\n", i);
}

} // path is valid
else
{
printf( "Error: path of sample not valid from Restore::retrieve()\n");
fprintf(stderr, "Error: path of sample not valid from Restore::retrieve()\n");
}
}
}
Expand Down