Refactoring of lib.fileio.auto_open function to work with subprocess (#266) #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reovirus
changed the title
Reovirus
changed the title
Reovirus
changed the title
Reovirus
changed the title
removing the global definition of loggers to satisfy latest flake8 update
agalitsyna
requested changes
Apr 21, 2025
| is_binary: bool=False | ||
|
|
||
| @staticmethod | ||
| def form_notfounderror_text(searched_tools: tp.List[str], is_read: bool) -> str: |
There was a problem hiding this comment.
Would be great to add comment message to each method: what it's doing. Very simple description is enough!
| raise ValueError(f'{self.__format} can not to be opened in {self.mode}') | ||
|
|
||
| checked_tools = [] | ||
| for possible_solution in COMMANDS[(self.__format, self.mode)]: |
There was a problem hiding this comment.
Just a brief annotation of the flow of checks will be great (one comment line for each critical point, no more)
| 'lz4': ['w', 'r', 'a'], | ||
| } | ||
|
|
||
| COMMANDS = { |
There was a problem hiding this comment.
Would be great to write down the logic in the comment here: the first command is the first choice, etc.
| self.command = possible_solution['command'].format(str(self.nproc)) | ||
| return | ||
|
|
||
| raise ValueError(self.form_notfounderror_text(checked_tools, self.mode=='r')) |
There was a problem hiding this comment.
Maybe comment line here will be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the CommandFormatter interface, encapsulating file operations and validations.
Added standard CLI response outputs to enhance user interaction.
MODES_TO_FILES_PRESET: format keys with values as lists of possible operation modes (read, write, append).
COMMANDS: format and mode keys with values as dictionaries containing:
tool: the tool's presence is verified in the system.
command: a command formatted for substituting the number of available processors (nproc).
This structure streamlines adding new formats without altering existing code.
Added capabilities for handling binary files.
This feature is not currently utilized but provides flexibility for future enhancements.
Transitioned to using subprocess for file operations, improving compatibility and performance.
P.S. The function signatures and responses of auto_open remain unchanged, ensuring backward compatibility. However, the implementation using the CommandFormatter class offers a more convenient and versatile approach, enhancing code maintainability and scalability.