Skip to content

Conversation

@emdann
Copy link

@emdann emdann commented May 7, 2023

Following discussion with @ivirshup in #144, this is a proposed implementation for a strand-aware expand operation, adding the option direction_col.

@nvictus
Copy link
Member

nvictus commented Apr 7, 2024

I migrated the strand-awareness logic to a new function bioframe.shift, basically following the proposal here.

Unlike expand, the semantics of shift always treats negative values as upstream and positive as downstream for both bounds of the ranges. expand itself could be deprecated.

@nvictus nvictus requested review from gfudenberg and golobor April 7, 2024 15:05
@nvictus nvictus force-pushed the main branch 2 times, most recently from 1875675 to b46897a Compare April 21, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants