Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Conversation

@Piasy
Copy link
Contributor

@Piasy Piasy commented May 9, 2021

No description provided.

@taste1981 taste1981 requested a review from jianjunz May 10, 2021 00:44
@taste1981
Copy link
Collaborator

@Piasy Thanks for you patch. I'm adding @jianjunz to review this.

@jianjunz
Copy link
Collaborator

Thanks for your change. One reason of having both RTCVideoDecoderH264.mm and RTCVideoDecoderH265.mm is HEVC is not included in upstream libwebrtc. Making too many changes to RTCVideoDecoderH264.mm will increase the effort during rebasing. So I would prefer to keep RTCVideoDecoderH264.mm unchanged. As this is a trade off, I'm open to merge these two files if it brings more benefits.

@Piasy
Copy link
Contributor Author

Piasy commented May 11, 2021

Hi @jianjunz , as you can see in the diff, the modification to RTCVideoEncoder/DecoderH264 isn't very large, only several #if #else #endif, I don't think it will increase much effort for future rebasing. And if we use separate files for H265, if upstream makes any update or improvement to H264 encoder/decoder, it's not easy to notice them, and apply those changes manually would be annoying.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants