refactor: use String for extension identifiers in metadata structures #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mise42
commented
Jul 2, 2025
mise42
commented
- Updated Metadata struct to use String for extensions and extension_fns to prevent loss of precision in frontend codes.
- Adjusted related mapping logic to convert identifiers to String.
* Updated Metadata struct to use String for extensions and extension_fns to prevent loss of precision in frontend codes. * Adjusted related mapping logic to convert identifiers to String.
mise42
added a commit
that referenced
this pull request
Jul 2, 2025
…#83) * Updated Metadata struct to use String for extensions and extension_fns to prevent loss of precision in frontend codes. * Adjusted related mapping logic to convert identifiers to String.
mise42
added a commit
that referenced
this pull request
Jul 26, 2025
downgrade to polkadot-stable2407 improve error handling in std env fix thiserror #[from] build: add .PHONY to Makefile (#82) refactor: use String for extension identifiers in metadata structures (#83) * Updated Metadata struct to use String for extensions and extension_fns to prevent loss of precision in frontend codes. * Adjusted related mapping logic to convert identifiers to String. improve test data display
mise42
added a commit
that referenced
this pull request
Jul 26, 2025
downgrade to polkadot-stable2407 improve error handling in std env fix thiserror #[from] build: add .PHONY to Makefile (#82) refactor: use String for extension identifiers in metadata structures (#83) * Updated Metadata struct to use String for extensions and extension_fns to prevent loss of precision in frontend codes. * Adjusted related mapping logic to convert identifiers to String. improve test data display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.