Skip to content

Add assertion for maze constraints and limit _random_floor_cell attempts #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gjorgji-Noveski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add assertion for maze constraints and limit _random_floor_cell attempts #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion reasoning_gym/games/maze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def validate(self) -> None:
assert self.max_dist >= self.min_dist, "max_dist must be >= min_dist"
assert self.min_grid_size >= 2, "min_grid_size must be >= 2"
assert self.max_grid_size >= self.min_grid_size, "max_grid_size must be >= min_grid_size"
assert self.min_grid_size - 2 >= self.min_dist, "min_grid_size - 2 must be >= min_dist"


class MazeDataset(ProceduralDataset):
Expand Down Expand Up @@ -152,11 +153,12 @@ def _generate_random_maze(self, rng: random.Random, size: int) -> list[list[str]
def _random_floor_cell(self, rng: random.Random, grid: list[list[str]]) -> tuple[int, int]:
"""Pick a random path cell inside the maze (not the border)."""
size = len(grid)
while True:
for _ in range(self.num_retries):
r = rng.randint(1, size - 2)
c = rng.randint(1, size - 2)
if grid[r][c] == self.path_char:
return (r, c)
raise RuntimeError(f"Could not find suitable path cell after {self.num_retries} attempts")

def _bfs_shortest_path(
self, grid: list[list[str]], start_r: int, start_c: int, goal_r: int, goal_c: int
Expand Down