Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending with custom manual instrumentation #5789

Merged
merged 13 commits into from
Jan 11, 2025
Merged

Extending with custom manual instrumentation #5789

merged 13 commits into from
Jan 11, 2025

Conversation

zeitlinger
Copy link
Member

Fixes #5713

@zeitlinger zeitlinger self-assigned this Dec 13, 2024
@zeitlinger zeitlinger requested a review from a team as a code owner December 13, 2024 14:27
@opentelemetrybot opentelemetrybot requested review from a team December 13, 2024 14:27
svrnm
svrnm requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

content/en/docs/zero-code/java/agent/annotations.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/api.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/spring-boot-starter/annotations.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/spring-boot-starter/api.md Outdated Show resolved Hide resolved
@zeitlinger
Copy link
Member Author

@svrnm can you check?

svrnm
svrnm requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

@zeitlinger
Copy link
Member Author

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

it's API to separate it from annotations - which also extend

@zeitlinger
Copy link
Member Author

@svrnm please check again

@zeitlinger
Copy link
Member Author

@svrnm can you check?

@svrnm
Copy link
Member

svrnm commented Dec 20, 2024

@svrnm can you check?

I did, but I'd like to get some feedback from @open-telemetry/java-approvers or @open-telemetry/java-instrumentation-approvers as well

@zeitlinger
Copy link
Member Author

@jack-berg can you check?

trask
trask reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sections for the Java agent and Spring Boot starter are great additions.

I only have question about how to structure the addition to the general API page.

content/en/docs/zero-code/java/spring-boot-starter/api.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/spring-boot-starter/api.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/spring-boot-starter/annotations.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/annotations.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/api.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/api.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/api.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team January 6, 2025 10:55
@zeitlinger zeitlinger force-pushed the extending-with-custom-manual-instrumenation branch from 1e96fae to 217dc46 Compare January 6, 2025 11:00
@cartermp cartermp added this pull request to the merge queue Jan 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2025
@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12727527132

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cartermp cartermp added this pull request to the merge queue Jan 11, 2025
Merged via the queue into open-telemetry:main with commit 292967a Jan 11, 2025
17 checks passed
@zeitlinger zeitlinger deleted the extending-with-custom-manual-instrumenation branch January 13, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg left review comments

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

@trask trask trask approved these changes

Assignees

@zeitlinger zeitlinger

Labels
sig:java
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to get a meter/tracer in Java agent or spring stater
7 participants
@zeitlinger @svrnm @cartermp @opentelemetrybot @trask @chalin @jack-berg