-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add link to blog post "Collecting OpenTelemetry-compliant Java logs from files" #5754
base: main
Are you sure you want to change the base?
add link to blog post "Collecting OpenTelemetry-compliant Java logs from files" #5754
Conversation
If it's worth linking to the blog post from the docs, I wonder if we shouldn't just incorporate the example into the documentation itself. @open-telemetry/docs-approvers, WDYT? |
Yeah, I would prefer to pull it in if it's still relevant content that's intended to be permanent. |
yes, blog posts become outdated over time and we do not intend to keep them updated. So the portions of the blog post that need to be updated should live in docs. |
@zeitlinger, if you agree, I'll create an issue for the transfer of the example in the blog to the docs and we can close this PR. Thanks! |
@jack-berg adding a complete example on this page would increase the size too much do you have an idea where we could add examples like this? |
Its a bit niche but probably not any more niche than examples we already have in there. |
that would be my preferred place as well, we can then either point to it from docs, or code-excerpt some of it eventually into the docs. |
I already have an executable, tested example - maybe we can use it as a starting point: https://github.com/grafana/docker-otel-lgtm/tree/main/examples/java/json-logging-otlp Testing up to the collector would be sufficient - but I don't know which tool does this. WDYT? |
Sure, if you bring that into the opentelemetry-java-examples repo we can link it from there. TIL about OATS, do you want to add that to the registry? This might also be interesting for open-telemetry/community#2427 |
@svrnm here's the PR: open-telemetry/opentelemetry-java-examples#547 |
|
No description provided.