Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to blog post "Collecting OpenTelemetry-compliant Java logs from files" #5754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger self-assigned this Dec 10, 2024
@zeitlinger zeitlinger requested a review from a team as a code owner December 10, 2024 17:45
@opentelemetrybot opentelemetrybot requested review from a team December 10, 2024 17:45
@tiffany76
Copy link
Contributor

If it's worth linking to the blog post from the docs, I wonder if we shouldn't just incorporate the example into the documentation itself. @open-telemetry/docs-approvers, WDYT?

@cartermp
Copy link
Contributor

Yeah, I would prefer to pull it in if it's still relevant content that's intended to be permanent.

@svrnm
Copy link
Member

svrnm commented Dec 11, 2024

yes, blog posts become outdated over time and we do not intend to keep them updated. So the portions of the blog post that need to be updated should live in docs.

@tiffany76
Copy link
Contributor

@zeitlinger, if you agree, I'll create an issue for the transfer of the example in the blog to the docs and we can close this PR. Thanks!

@zeitlinger
Copy link
Member Author

@jack-berg adding a complete example on this page would increase the size too much

do you have an idea where we could add examples like this?

@jack-berg
Copy link
Member

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷

Its a bit niche but probably not any more niche than examples we already have in there.

@svrnm
Copy link
Member

svrnm commented Dec 16, 2024

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷

Its a bit niche but probably not any more niche than examples we already have in there.

that would be my preferred place as well, we can then either point to it from docs, or code-excerpt some of it eventually into the docs.

@zeitlinger
Copy link
Member Author

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷

Its a bit niche but probably not any more niche than examples we already have in there.

I already have an executable, tested example - maybe we can use it as a starting point: https://github.com/grafana/docker-otel-lgtm/tree/main/examples/java/json-logging-otlp

  1. Full k8s setup
  2. sends data to loki
  3. uses OATS for tests - which queries loki

Testing up to the collector would be sufficient - but I don't know which tool does this.

WDYT?

@svrnm
Copy link
Member

svrnm commented Dec 16, 2024

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷
Its a bit niche but probably not any more niche than examples we already have in there.

I already have an executable, tested example - maybe we can use it as a starting point: grafana/docker-otel-lgtm@main/examples/java/json-logging-otlp

1. Full k8s setup

2. sends data to [loki](https://github.com/grafana/loki?rgh-link-date=2024-12-16T10%3A44%3A57Z)

3. uses [OATS](https://github.com/grafana/oats/tree/main/yaml?rgh-link-date=2024-12-16T10%3A44%3A57Z) for tests - which queries loki

Testing up to the collector would be sufficient - but I don't know which tool does this.

WDYT?

Sure, if you bring that into the opentelemetry-java-examples repo we can link it from there.

TIL about OATS, do you want to add that to the registry? This might also be interesting for open-telemetry/community#2427

@zeitlinger
Copy link
Member Author

Sure, if you bring that into the opentelemetry-java-examples repo we can link it from there.

@svrnm here's the PR: open-telemetry/opentelemetry-java-examples#547

@zeitlinger
Copy link
Member Author

do you want to add that to the registry?

#5819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants