Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for non tokio main #2520

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cijothomas
Copy link
Member

Fixes #2402
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner January 15, 2025 21:24
@cijothomas cijothomas added the integration tests Run integration tests label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (b53c19e) to head (cd652b0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2520   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22944   22944           
=====================================
  Hits       17879   17879           
  Misses      5065    5065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas marked this pull request as draft January 16, 2025 00:40
@cijothomas
Copy link
Member Author

marking draft to fix and isolate the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate tonic can be used in blocking scenarios/non-tokio context
1 participant