Skip to content

feat: Geneva uploader - Add ingestion service #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
May 2, 2025

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Apr 3, 2025

Fixes #
This PR is stacked on top of #227, so it appears quite large. No need to review it yet — I’ll mark it as ready once #227 is merged.

PR is ready for review now

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Left some suggestions.

@lalitb lalitb merged commit 167d82f into open-telemetry:main May 2, 2025
19 of 21 checks passed
@lalitb
Copy link
Member Author

lalitb commented May 2, 2025

Looks good overall! Left some suggestions.

Appreciate the thorough review, @utpilla. The suggested changes have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants