-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Geneva uploader - Add ingestion service #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lalitb
merged 45 commits into
open-telemetry:main
from
lalitb:geneva-uploader-ingestion-service
May 2, 2025
Merged
feat: Geneva uploader - Add ingestion service #235
lalitb
merged 45 commits into
open-telemetry:main
from
lalitb:geneva-uploader-ingestion-service
May 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entelemetry-rust-contrib into geneva-uploader-config-service
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/mod.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/mod.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/opentelemetry-exporter-geneva/src/logs/exporter.rs
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 26, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 29, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/config_service/client.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 30, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/mod.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 30, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/mod.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 30, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 30, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Apr 30, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Left some suggestions.
…/opentelemetry-rust-contrib into geneva-uploader-ingestion-service
Appreciate the thorough review, @utpilla. The suggested changes have been applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This PR is stacked on top of #227, so it appears quite large. No need to review it yet — I’ll mark it as ready once #227 is merged.PR is ready for review now
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes