feat: Ruby Logger instrumentation #983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ruby-contrib into logger-instrumentation
…elle/opentelemetry-ruby-contrib into logger-instrumentation
Appraisal can't install gems from a git source. Since the appraisal is only necessary for active_support_logger, disable those tests while working on other features.
chore: Allow logger patch tests to run
…-ruby-contrib into logger-instrumentation
…elle/opentelemetry-ruby-contrib into logger-instrumentation
feat: map logger level to OTel level
…ntelemetry-ruby-contrib into logger-instrumentation
Rails 7.1+ uses ActiveSupport::BroadcastLogger. This needs to protect against emitting duplicate logs in a different way than ActiveSupport::Logger.broadcast. Emits the log record for the first logger in the broadcast, skip the others. Reset everything at the end of the method call.
kaylareopelle
changed the title
* Add references to released logs gems * Test Rails 7.0 - 8.0 * Rubocop * Set gem version
…ntelemetry-ruby-contrib into logger-instrumentation
kaylareopelle
commented
Dec 5, 2024
| severity_text: severity, | ||
| severity_number: severity_number(severity), | ||
| timestamp: datetime, | ||
| body: msg, |
There was a problem hiding this comment.
New Relic uses formatted_message here. This includes both the progname and the message in the body, whereas msg does not include the progname. Which seems more appropriate?
Test the outcome rather than the presence of variables
|
I'm still trying to figure out why one of the tests is failing on the CI, but passes locally. However, everything except the ActiveSupportLogger code should be ready for review. Please take a look and I'll push the update as soon as I can! |
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This an OpenTelemetry logs bridge for Ruby's standard Logger library.
It also includes patches to
ActiveSupport::Logger.broadcastand theActiveSupport::BroadcastLoggerto emit only one log record for a broadcast.@khushijain21 is a co-author of this PR and contributed functionality as part of her LFX mentorship with OpenTelemetry in 2024.
TODOs:
Verify OpenTelemetry logs aren't emitted as LogRecords (or should they be?)Seems they canDepending on when this is released, add support for Rails 8 structured logging(structured logging pushed to Rails 8.1)Closes #668