Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bundler conflict warnings #951

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: Bundler conflict warnings #951

merged 4 commits into from
Apr 30, 2024

Conversation

arielvalentin
Copy link
Collaborator

Fixes #938

@arielvalentin arielvalentin self-assigned this Apr 27, 2024
@arielvalentin arielvalentin force-pushed the fix-bundler-conflict-warnings branch from 128003b to 19fc6c6 Compare April 27, 2024 23:12
@arielvalentin arielvalentin marked this pull request as ready for review April 27, 2024 23:50
@arielvalentin arielvalentin requested review from a team April 27, 2024 23:50
robbkidd
robbkidd approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

In a separate issue/PR, I am even in favor of declaring all development dependencies in the gem's Gemfile instead of the gem's gemspec.

@arielvalentin
Copy link
Collaborator Author

@robbkidd Gotcha. Would you be up for opening an issue?

@arielvalentin arielvalentin merged commit d3e9e3a into open-telemetry:main Apr 30, 2024
51 checks passed
@arielvalentin arielvalentin deleted the fix-bundler-conflict-warnings branch April 30, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

Assignees

@arielvalentin arielvalentin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gemspec Development Dependency Warning
2 participants
@arielvalentin @robbkidd